-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-90978: test_ssl of test_asyncio uses LONG_TIMEOUT #92402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
On slow buildbot workers, some test_ssl tests fail randomly because of short timeout (30 seconds). Use support.LONG_TIMEOUT instead which is longer and also adjusted (by regrtest --timeout option) on buildbot workers known to be slow.
Python 3.10 already uses LONG_TIMEOUT:
|
cc @zooba |
There is no need to backport the change to Python 3.10. In Python 3.10, it's a different filename and it already uses LONG_TIMEOUT. |
@pablogsal: Here is a fix for the x86 Gentoo buildbot. |
test_asyncio.test_create_server_ssl_over_ssl() failed on x86 Gentoo Non-Debug with X 3.x: https://buildbot.python.org/all/#/builders/58/builds/2300 IMO the problem is the hardcoded timeout of 30 seconds. This change increases it to 5 minutes (or longer, it's adapted to the buidbot --timeout argument).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the PR!
On slow buildbot workers, some test_ssl tests fail randomly because
of short timeout (30 seconds). Use support.LONG_TIMEOUT instead which
is longer and also adjusted (by regrtest --timeout option) on
buildbot workers known to be slow.