gh-87901: Add encoding to os.popen #92374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
added
stdlib
hauntsaninja
reviewed
May 7, 2022
| if not isinstance(cmd, str): | ||
| raise TypeError("invalid cmd type (%s, expected string)" % type(cmd)) | ||
| if mode not in ("r", "w"): | ||
| raise ValueError("invalid mode %r" % mode) | ||
| if buffering == 0 or buffering is None: | ||
| raise ValueError("popen() does not support unbuffered streams") | ||
| import subprocess, io | ||
| encoding = io.text_encoding(encoding) |
There was a problem hiding this comment.
Maybe I'm missing something obvious, but shouldn't this be passed to subprocess.Popen?
There was a problem hiding this comment.
Thank you. I was too rushed.
I will fix it in follow up PR.
#92415
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #87901