gh-92118: Add test for traceback when exception is modified by ExitStack.__exit__ #92339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ExitStack.__exit__
serhiy-storchaka
approved these changes
May 5, 2022
Lib/test/test_contextlib.py
Outdated
|
|
||
| self.assertIsInstance(exc, ValueError) | ||
| ve_frames = traceback.extract_tb(exc.__traceback__) | ||
| self.assertEqual(len(ve_frames), 5) |
There was a problem hiding this comment.
It is redundant, And if it fail, the report will be less informative than failing the test which compares lists.
It is. |
|
Hmm. contextlib_async tests use this test and get a different traceback. |
|
You can parametrize the test. Set the expected result as an attribute of the class. |
|
Thanks. The 3.10 backport will fail because it doesn't have import traceback, but I'll fix it. |
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 5, 2022
…(Async)ExitStack.__exit__ (pythonGH-92339) (cherry picked from commit e65e587) Co-authored-by: Irit Katriel <[email protected]>
|
GH-92343 is a backport of this pull request to the 3.10 branch. |
iritkatriel
pushed a commit
that referenced
this pull request
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.