gh-91795: Update build optimization part of PCbuild/readme.txt #91849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zooba
reviewed
Apr 25, 2022
PCbuild/readme.txt
Outdated
|
|
||
| See | ||
| http://msdn.microsoft.com/en-us/library/e7k32f4k(VS.140).aspx | ||
| https://docs.microsoft.com/en-us/cpp/build/profile-guided-optimizations?view=msvc-170 |
There was a problem hiding this comment.
Suggested change
| https://docs.microsoft.com/en-us/cpp/build/profile-guided-optimizations?view=msvc-170 | |
| https://docs.microsoft.com/cpp/build/profile-guided-optimizations |
The query param and language will be added automatically, so it'll stay up to date and automatically translate for people.
There was a problem hiding this comment.
Yes, I missed it.
| @@ -0,0 +1,2 @@ | |||
| Updated build_pgo part under 'Profile Guided Optimization' according to the | |||
| current build script. Updated Microsoft docs link. | |||
There was a problem hiding this comment.
Don't need a NEWS entry for this. Delete the file and I'll add the tag to skip the check
zooba
added
needs backport to 3.11
|
Thanks @fatihkabakk for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 8, 2023
…ythonGH-91849) (cherry picked from commit 906b73b) Co-authored-by: Fatih <[email protected]>
|
GH-107776 is a backport of this pull request to the 3.12 branch. |
|
GH-107777 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 8, 2023
…ythonGH-91849) (cherry picked from commit 906b73b) Co-authored-by: Fatih <[email protected]>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Aug 16, 2023
…GH-91849) (GH-107777) (cherry picked from commit 906b73b) Co-authored-by: Fatih <[email protected]>
Yhg1s
pushed a commit
that referenced
this pull request
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.bat's new arguments main branchbuild.bat