gh-91636: Don't clear required fields of function objects #91651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
reviewed
Apr 19, 2022
Objects/funcobject.c
Outdated
| Py_CLEAR(op->func_module); | ||
| Py_CLEAR(op->func_defaults); | ||
| Py_CLEAR(op->func_kwdefaults); | ||
| Py_CLEAR(op->func_doc); | ||
| Py_CLEAR(op->func_dict); | ||
| Py_CLEAR(op->func_closure); | ||
| Py_CLEAR(op->func_annotations); | ||
| /* Below are required attributes, so to keep everything in | ||
| * a consistent state, don't clear them. They're immutable, | ||
| * so they can't participate in cycles anyway. |
There was a problem hiding this comment.
Did you confirm that Unicode subclass are not allowed?
There was a problem hiding this comment.
Ah, good catch, it can be a subclass:
>>> def f():
... pass
...
>>> class S(str):
... pass
...
>>> f.__name__ = S("???") # no errorI don't know what a good solution is.
methane
approved these changes
Apr 20, 2022
|
Does this require backports? |
sweeneyde
added
needs backport to 3.9
|
3.10 and 3.9 have no |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#91636