Revert "Fix misindented yaml in logging how to example (GH-8604)" #9081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 10b59f1.
|
Thanks @Natim for the PR, and @zhangyangyu for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 10, 2018
…" (pythonGH-9081) This reverts commit 10b59f1. (cherry picked from commit 290a60b) Co-authored-by: Rémy HUBSCHER <[email protected]>
|
GH-9129 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 10, 2018
…" (pythonGH-9081) This reverts commit 10b59f1. (cherry picked from commit 290a60b) Co-authored-by: Rémy HUBSCHER <[email protected]>
|
GH-9130 is a backport of this pull request to the 3.6 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 10, 2018
…-9081) This reverts commit 10b59f1. (cherry picked from commit 290a60b) Co-authored-by: Rémy HUBSCHER <[email protected]>
|
It's back. 🎉 Thanks for coming back to fix it. :-) |
miss-islington
added a commit
that referenced
this pull request
Sep 10, 2018
…-9081) This reverts commit 10b59f1. (cherry picked from commit 290a60b) Co-authored-by: Rémy HUBSCHER <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the logging cookbook, I realized my mistake.
This reverts commit 10b59f1.
Revert PR #8604
This needs also to be backported to Branch 3.7 and branch 3.6