Skip to content

bpo-33898: Fix pathlib issues with Windows device paths #8671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from

Conversation

AlbinaGiliazova
Copy link

@AlbinaGiliazova AlbinaGiliazova commented Aug 4, 2018

https://bugs.python.org/issue33898
Now it should work correctly for all mentioned test examples but no changes made for GlobalRoot case as no examples were provided.

https://bugs.python.org/issue33898

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

You can check yourself
to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@AlbinaGiliazova
Copy link
Author

Wow! It passed whitespace checks finally. I thought it's impossible. Btw CLA is signed but waiting for approvement.

Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this patch! A couple of minor suggestions, and a question or two.

@AlbinaGiliazova
Copy link
Author

I've made the improvements requested. Should I do something else or just wait for another review?

@csabella
Copy link
Contributor

@zooba It appears that @AlbinaGiliazova addressed all your review concerns. Would you have an opportunity to review the changes? Thanks!

Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping! We're nearly there, just little nits that we don't want making it into the codebase.

@csabella
Copy link
Contributor

@eryksun, would you be able to review this per @zooba's request on the bug tracker. Thanks!

@eryksun
Copy link
Contributor

eryksun commented May 24, 2019

@csabella, thanks for the reminder. I missed the tracker notification.

@csabella
Copy link
Contributor

@eryksun, ping

@AlbinaGiliazova
Copy link
Author

Hello. How do I make backports. Is there an instruction?

@csabella csabella added the needs backport to 3.9 only security fixes label May 23, 2020
@csabella
Copy link
Contributor

@AlbinaGiliazova, you wouldn't need to do anything for the backports unless the bot is unable to create them.

@barneygale
Copy link
Contributor

Code looks good to me, but this needs tests!

@ambv
Copy link
Contributor

ambv commented May 17, 2022

This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today.

@barneygale
Copy link
Contributor

Thanks for this PR, @AlbinaGiliazova! The issue has now been resolved by another PR, so I'll close this PR. Hope that's alright, thanks again.

@barneygale barneygale closed this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants