Skip to content

bpo-33894: Clarified the tempdir documentation #7829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2018
Merged

bpo-33894: Clarified the tempdir documentation #7829

merged 1 commit into from
Jun 21, 2018

Conversation

srinivasreddy
Copy link
Contributor

@srinivasreddy srinivasreddy commented Jun 20, 2018 •
edited by bedevere-bot
Loading

@srinivasreddy srinivasreddy changed the title Clarified the tempdir documentation bpo-33894: Clarified the tempdir documentation Jun 20, 2018
ericvsmith
ericvsmith requested changes Jun 20, 2018
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than not adding the NEWS entry, this looks good. Thanks!

Misc/NEWS.d/next/Documentation/2018-06-21-01-29-36.bpo-33894.tsesJ.rst Outdated
@@ -0,0 +1 @@
Clarified the `tempdir` documentation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this merits a NEWS entry. Let's delete this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@srinivasreddy
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

ericvsmith
ericvsmith approved these changes Jun 21, 2018
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the change!

@ericvsmith ericvsmith merged commit 940ae60 into python:master Jun 21, 2018
@miss-islington
Copy link
Contributor

Thanks @srinivasreddy for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 21, 2018
@srinivasreddy @miss-islington
Clarified the tempfile.tempdir documentation (pythonGH-7829)
03a4cad 
(cherry picked from commit 940ae60)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <[email protected]>
@bedevere-bot
Copy link

GH-7841 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Sorry, @srinivasreddy and @ericvsmith, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 940ae608566fd4446ff92a22705f646cde1d087c 2.7

@bedevere-bot
Copy link

GH-7842 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 21, 2018
@srinivasreddy @miss-islington
Clarified the tempfile.tempdir documentation (pythonGH-7829)
d124610 
(cherry picked from commit 940ae60)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <[email protected]>
ericvsmith pushed a commit that referenced this pull request Jun 21, 2018
@miss-islington @srinivasreddy @ericvsmith
Clarified the tempfile.tempdir documentation (GH-7829) (GH-7841)
fee52e3 
(cherry picked from commit 940ae60)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <[email protected]>
ericvsmith pushed a commit that referenced this pull request Jun 21, 2018
@miss-islington @srinivasreddy @ericvsmith
bpo-33894: Clarified the tempfile.tempdir documentation (GH-7829) (GH…
b225cb7 
…-7842)

(cherry picked from commit 940ae60)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees

@ericvsmith ericvsmith

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srinivasreddy @bedevere-bot @miss-islington @ericvsmith @the-knights-who-say-ni