bpo-33873: Add warning when using less than 3 warmup runs in runtest.py.
#7736
Conversation
pablogsal
changed the title
runtest.py.runtest.py.
Lib/test/libregrtest/runtest.py
Outdated
| @@ -98,6 +98,13 @@ def runtest(ns, test): | |||
|
|
|||
| output_on_failure = ns.verbose3 | |||
|
|
|||
| if ns.huntrleaks: | |||
There was a problem hiding this comment.
If you put the warning here, you get one warning per test file. It would be better to put it in Regrtest.runtest().
There was a problem hiding this comment.
My bad. I did not notice this because I usually only run one file.
Lib/test/libregrtest/runtest.py
Outdated
| warmup, repetitions, _ = ns.huntrleaks | ||
| if warmup < 3: | ||
| msg = ("WARNING: Using less than 3 warmup repetitions can " | ||
| "give false positives!") |
There was a problem hiding this comment.
Somewhere you should mention the option "--huntrleaks/-R".
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
Lib/test/libregrtest/main.py
Outdated
| if self.ns.huntrleaks: | ||
| warmup, repetitions, _ = self.ns.huntrleaks | ||
| if warmup < 3: | ||
| msg = ("WARNING: Runing tests with --huntrleaks/-R and less than " |
* bpo-33718: regrtest: use format_duration() to display failed tests (GH-7686) * Enhance also format_duration(): work on integers and rounds towards +infinity (math.ceil). * Write unit tests on format_duration() (cherry picked from commit 4ffe9c2) * bpo-33873: regrtest: Add warning on -R 1:3 (GH-7736) regrtest: Add warning when using less than 3 warmup runs like -R 1:3. (cherry picked from commit cac4fef) * bpo-33873: Fix bug in `runtest.py` and add checks for invalid `-R` parameters (GH-7735) Fix bug in `Lib/test/libregrtest/runtest.py` that makes running tests an extra time than the specified number of runs. Add check for invalid --huntrleaks/-R parameters. (cherry picked from commit 58ed730)
* bpo-33718: regrtest: use format_duration() to display failed tests (GH-7686) * Enhance also format_duration(): work on integers and rounds towards +infinity (math.ceil). * Write unit tests on format_duration() (cherry picked from commit 4ffe9c2) * bpo-33873: regrtest: Add warning on -R 1:3 (GH-7736) regrtest: Add warning when using less than 3 warmup runs like -R 1:3. (cherry picked from commit cac4fef) * bpo-33873: Fix bug in `runtest.py` and add checks for invalid `-R` parameters (GH-7735) Fix bug in `Lib/test/libregrtest/runtest.py` that makes running tests an extra time than the specified number of runs. Add check for invalid --huntrleaks/-R parameters. (cherry picked from commit 58ed730)
* bpo-33718: regrtest: use format_duration() to display failed tests (GH-7686) * Enhance also format_duration(): work on integers and rounds towards +infinity (math.ceil). * Write unit tests on format_duration() (cherry picked from commit 4ffe9c2) * bpo-33873: regrtest: Add warning on -R 1:3 (GH-7736) regrtest: Add warning when using less than 3 warmup runs like -R 1:3. (cherry picked from commit cac4fef) * bpo-33873: Fix bug in `runtest.py` and add checks for invalid `-R` parameters (GH-7735) Fix bug in `Lib/test/libregrtest/runtest.py` that makes running tests an extra time than the specified number of runs. Add check for invalid --huntrleaks/-R parameters. (cherry picked from commit 58ed730) (cherry picked from commit d1f9481)
https://bugs.python.org/issue33873