Improve the subprocess restore_signals=True test. #7414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't testing functionality. Now it is (on Linux anyways).
gpshead
added
tests
|
This just improves a unittest so I'm intending to skip an issue and news entry for it. |
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 5, 2018
It wasn't testing functionality. Now it is (on Linux anyways). (cherry picked from commit 5f3d04f) Co-authored-by: Gregory P. Smith <[email protected]>
|
GH-7437 is a backport of this pull request to the 3.7 branch. |
gpshead
added a commit
that referenced
this pull request
Jun 7, 2018
It wasn't testing functionality. Now it is (on Linux anyways). (cherry picked from commit 5f3d04f) Co-authored-by: Gregory P. Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't testing functionality. Now it is (on Linux anyways).