bpo-33720: Reduces maximum marshal recursion depth on release builds. #7401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Jun 4, 2018
| if os.name == 'nt' and hasattr(sys, 'gettotalrefcount'): | ||
| # BUG: https://bugs.python.org/issue33720 | ||
| # Windows always limits the maximum depth on release and debug builds | ||
| #if os.name == 'nt' and hasattr(sys, 'gettotalrefcount'): |
There was a problem hiding this comment.
No need to mark it as a temporary fix, I suggest:
# Windows always limits the maximum depth on release and debug builds
if os.name == 'nt':
There was a problem hiding this comment.
But I want it to be a temporary fix :) I want the compiler bug that's generating bad stack frames to be fixed. Hopefully I'll hear back from them today whether it's really a bug or not though - if there's a good reason for it then this can become a permanent change.
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-7405 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 4, 2018
…pythonGH-7401) (cherry picked from commit 2a4a62b) Co-authored-by: Steve Dower <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jun 4, 2018
…GH-7401) (cherry picked from commit 2a4a62b) Co-authored-by: Steve Dower <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33720