Ignore what's new for MentionBot #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because everybody is editing in every PR and that's finding wrong reviewers.
|
@Carreau, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dstufft, @brettcannon and @skrah to be potential reviewers. |
|
For context I was pinged as a potential reviewer on #505, which I definitively don't have the skills to review, so I assumed it was the what's new. |
dstufft
requested changes
Mar 6, 2017
.mention-bot
Outdated
| @@ -4,7 +4,8 @@ | |||
| "findPotentialReviewers": true, | |||
| "fileBlacklist": [ | |||
| "Misc/ACKS", | |||
| "Misc/NEWS" | |||
| "Misc/NEWS", | |||
| "Doc/whatsnew/*.rst", | |||
There was a problem hiding this comment.
This is a JSON file and cannot have a trailing comma.
dstufft
approved these changes
Mar 6, 2017
|
Thanks! |
|
Ah, I guess tests are just failing on |
|
@dstufft yep, some breakage about keyword arguments; looked like it wasn't related to this |
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
The current logic is buggy and not worth the trouble. Core devs and triagers will be handling this event manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because everybody is editing in every PR and that's finding wrong
reviewers.