bpo-32030: Fix _Py_InitializeEx_Private() #4649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_Py_InitializeEx_Private() now calls _PyMainInterpreterConfig_ReadEnv() to read environment variables PYTHONHOME and PYTHONPATH, and set the program name.
|
While testing ptest.c attached to https://bugs.python.org/issue20891 I found a regression that I introduced during https://bugs.python.org/issue32030 refactoring. When Python is embedded, calling Py_Initialize() doesn't read PYTHONPATH nor PYTHONHOME anymore. This change fixes it. I'm not sure if Py_Initialize() is supposed to read PYTHON* environment variables. Usually in case of doubt, I look at Python version N-1, so Python 3.6 in this case. Python 3.6 does read PYTHONPATH and PYTHONHOME in Py_Initialize() (except if Py_IgnoreEnvironmentFlag is non-zero). |
|
I had to push this fix quickly to be able to write an unit test for my https://bugs.python.org/issue20891 fix: the PR #4650. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Py_InitializeEx_Private() now calls
_PyMainInterpreterConfig_ReadEnv() to read environment variables
PYTHONHOME and PYTHONPATH, and set the program name.
https://bugs.python.org/issue32030