bpo-29406: Prevent SSL socket leaking in asyncio #4402
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvetlov
changed the title
Lib/asyncio/sslproto.py
Outdated
| def _on_shutdown_timeout(self): | ||
| if self._transport is not None: | ||
| self._fatal_error( | ||
| futures.TimeoutError(), 'Can not complete shitdown operation') |
There was a problem hiding this comment.
Good catch, thanks!
|
Should this PR be closed? |
|
Please let me review first. |
|
I thought you've already merged something that fixes this, no? |
|
What's the status of this? |
fantix
added a commit
to fantix/uvloop
that referenced
this pull request
Jul 10, 2018
fantix
added a commit
to fantix/uvloop
that referenced
this pull request
Jul 10, 2018
fantix
added a commit
to fantix/uvloop
that referenced
this pull request
Aug 15, 2018
serhiy-storchaka
added
type-bug
|
ping... |
|
I removed the " needs backport to 3.6" label, the 3.6 branch no long accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue29406
Supersedes #2269