Skip to content

bpo-31825: Fixed OverflowError in the 'unicode-escape' codec #4058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2017
Merged

bpo-31825: Fixed OverflowError in the 'unicode-escape' codec #4058

merged 2 commits into from
Oct 20, 2017

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 20, 2017 •
edited by bedevere-bot
Loading

and in codecs.escape_decode() when decode an escaped non-ascii byte.

https://bugs.python.org/issue31825

@serhiy-storchaka
bpo-31825: Fixed OverflowError in the 'unicode-escape' codec
8a69c23 
and in codecs.escape_decode() when decode an escaped non-ascii byte.
@serhiy-storchaka serhiy-storchaka added needs backport to 3.6 type-bug An unexpected behavior, bug, or error labels Oct 20, 2017
ericvsmith
ericvsmith approved these changes Oct 20, 2017
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (after fixing the one small typo).

Misc/NEWS.d/next/Core and Builtins/2017-10-20-14-07-46.bpo-31825.gJvmGW.rst Outdated
@@ -0,0 +1,2 @@
Fixed OverflowError in the 'unicode-escape' codec and in
codecs.escape_decode() when decode an scaped non-ascii byte.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: scaped -> escaped.

ericvsmith
ericvsmith approved these changes Oct 20, 2017
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

vstinner
vstinner approved these changes Oct 20, 2017
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 56cb465 into python:master Oct 20, 2017
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the escape-decode-invalid-non-ascii branch October 20, 2017 14:08
@bedevere-bot
Copy link

GH-4059 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2017
@serhiy-storchaka @miss-islington
bpo-31825: Fixed OverflowError in the 'unicode-escape' codec (pythonG…
6fcce46 
…H-4058)

and in codecs.escape_decode() when decode an escaped non-ascii byte.
(cherry picked from commit 56cb465)
serhiy-storchaka pushed a commit that referenced this pull request Oct 20, 2017
@miss-islington @serhiy-storchaka
bpo-31825: Fixed OverflowError in the 'unicode-escape' codec (GH-4058) (
1e78ed6 
#4059)

and in codecs.escape_decode() when decode an escaped non-ascii byte.
(cherry picked from commit 56cb465)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @miss-islington @bedevere-bot @vstinner @ericvsmith