bpo-31233: socketserver.ThreadingMixIn.server_close() #3523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
socketserver.ThreadingMixIn now keeps a list of non-daemonic threads to wait until all these threads complete in server_close().
vstinner
changed the title
|
TODO: re-enable skipped tests in test_logging Problem: test.test_logging.SocketHandlerTest.test_output() hangs by doing that. |
|
Should server_close() calls self.close_request(request) on thread requests? |
Fix SocketHandlerTest.tearDown(): close the socket handler before stopping the server, so the server can join threads.
vstinner
changed the title
|
This change is a temporary solution until we agree how to handle these threads and child processes in socketserver. |
|
This PR now requires PR #3524 to prevent warnings re-introduced in test_logging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
socketserver.ThreadingMixIn now keeps a list of non-daemonic threads
to wait until all these threads complete in server_close().
https://bugs.python.org/issue31233