bpo-29660: traceback: Document that etype is ignored in some places. #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadmium
reviewed
Feb 27, 2017
Doc/library/traceback.rst
Outdated
|
|
||
| The optional *limit* argument has the same meaning as for :func:`print_tb`. | ||
| If *chain* is true (the default), then chained exceptions (the | ||
| :attr:`__cause__` or :attr:`__context__` attributes of the exception) will be | ||
| printed as well, like the interpreter itself does when printing an unhandled | ||
| exception. | ||
|
|
||
| .. versionchanged:: 3.5 | ||
| The *etype* argument is ignored and infered from the type of *value*. |
Doc/library/traceback.rst
Outdated
| @@ -468,5 +474,5 @@ This last example demonstrates the final few formatting functions: | |||
| [' File "spam.py", line 3, in <module>\n spam.eggs()\n', | |||
| ' File "eggs.py", line 42, in eggs\n return "bacon"\n'] | |||
| >>> an_error = IndexError('tuple index out of range') | |||
| >>> traceback.format_exception_only(type(an_error), an_error) | |||
| >>> traceback.format_exception_only("ignored parameter", an_error) | |||
There was a problem hiding this comment.
Does not seem to be the case for “format_exception_only”
Doc/library/traceback.rst
Outdated
| @@ -372,7 +378,7 @@ exception and traceback: | |||
| print("*** print_tb:") | |||
| traceback.print_tb(exc_traceback, limit=1, file=sys.stdout) | |||
| print("*** print_exception:") | |||
| traceback.print_exception(exc_type, exc_value, exc_traceback, | |||
| traceback.print_exception("ignored parameter", exc_value, exc_traceback, | |||
There was a problem hiding this comment.
This does not seem ideal. It is less compatible with older Python versions. If it needs clarifying at all, perhaps a comment would be better?
vstinner
changed the title
Carreau
force-pushed
the
doccument-deprecated-etype
branch
from
1069939 to
b4727b6
Compare
|
Thanks, sorry for the delay to fix. Comments should be addressed. |
Mariatta
reviewed
May 17, 2017
Doc/library/traceback.rst
Outdated
| @@ -372,6 +378,7 @@ exception and traceback: | |||
| print("*** print_tb:") | |||
| traceback.print_tb(exc_traceback, limit=1, file=sys.stdout) | |||
| print("*** print_exception:") | |||
| # exc_type below ignored on 3.5 and later | |||
There was a problem hiding this comment.
is ignored on 3.5 and later
The same for below :)
Mariatta
approved these changes
Jun 1, 2017
|
Thanks @Carreau 🎉 |
Carreau
added a commit
to Carreau/cpython
that referenced
this pull request
Jun 2, 2017
…aces. (pythonGH-344) (cherry picked from commit cdb89cd)
Carreau
added a commit
to Carreau/cpython
that referenced
this pull request
Jun 2, 2017
…aces. (pythonGH-344) (cherry picked from commit cdb89cd)
This was referenced Jun 2, 2017
Mariatta
pushed a commit
that referenced
this pull request
Jun 2, 2017
Mariatta
pushed a commit
that referenced
this pull request
Jun 2, 2017
akruis
pushed a commit
to stackless-dev/stackless
that referenced
this pull request
Nov 1, 2017
akruis
pushed a commit
to stackless-dev/stackless
that referenced
this pull request
Nov 1, 2017
akruis
pushed a commit
to stackless-dev/stackless
that referenced
this pull request
Nov 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://bugs.python.org/issue29660