Skip to content

bpo-44733: max_tasks_per_child + fork not allowed #32187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

loganasherjones
Copy link
Contributor

@loganasherjones loganasherjones commented Mar 30, 2022

These changes ensure that if a user specifies max_tasks_per_child but no mp_context, a usable mp_context is generated automatically for them. If the user specified the fork context, then an error will be thrown.

For more information please see:

https://bugs.python.org/issue44733

@loganasherjones
Copy link
Contributor Author

ping @gpshead don't really know who else to ping about this.

Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test please?

@gpshead
Copy link
Member

gpshead commented Apr 24, 2022

Related, I've got #91587 to do this. I'll reconcile these two and get one merged within the next couple weeks.

@gpshead
Copy link
Member

gpshead commented May 6, 2022

Taken care of in fa4f0a1 via my other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants