Skip to content

bpo-46510: simplify exception handling code in xmlrpc #30878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2022
Merged

bpo-46510: simplify exception handling code in xmlrpc #30878

merged 1 commit into from
Jan 25, 2022

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jan 25, 2022 •
edited
Loading

All of these are covered by tests.

https://bugs.python.org/issue46510

@iritkatriel iritkatriel requested a review from vstinner January 25, 2022 07:51
@iritkatriel iritkatriel changed the title bpo-46510: remove Python2-style exception handling code in xmlrpc bpo-46510: simplify exception handling code in xmlrpc Jan 25, 2022
vstinner
vstinner approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I would be better to only catch Exception, rather than BaseException, but it should be addressed in a separated PR if anyone cares. This change is more a refactoring, it's better if it doesn't change the behavior ;-)

@iritkatriel
Copy link
Member Author

This change is more a refactoring, it's better if it doesn't change the behavior ;-)

Exactly - I don't know the context enough to know whether just Exception is ok.

Thank you for the review.

@iritkatriel iritkatriel merged commit d69d3d8 into python:main Jan 25, 2022
@iritkatriel iritkatriel deleted the bpo-46510-1 branch December 7, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iritkatriel @vstinner @kumaraditya303 @the-knights-who-say-ni @bedevere-bot