bpo-46219, 46221: simplify except* implementation following exc_info changes. Move helpers to exceptions.c. Do not assume that exception groups are truthy. #30289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
commented
Dec 29, 2021
iritkatriel
changed the title
This reverts commit 1c05b92.
|
@erlend-aasland would you have time to review this? It’s mostly moving code from ceval.c to exceptions.c. Would be nice to get it into the next alpha release (due to be cut tomorrow) so it gets tested in close to final form. |
erlend-aasland
approved these changes
Jan 2, 2022
|
Thank you @erlend-aasland, @brandtbucher and @ericsnowcurrently for the reviews (on this an on PR30302 which contained the functional changes in this PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functional except* changes were reviewed under PR30302 - I think they should be split out and not committed together with the POP_EXCEPT_AND_RERAISE change.
Otherwise, this just moves code from ceval.c to exceptions.c and sets me up to get a notification for PRs touching exceptions and tracebacks.
https://bugs.python.org/issue46221
https://bugs.python.org/issue46219