-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-90213: Speed up right shifts of negative integers #30277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
markshannon
merged 15 commits into
python:main
from
mdickinson:faster-rshift-of-negative
May 2, 2022
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9bf9dcd
bpo-46055: Speed up right shifts of negative integers
mdickinson ad69e48
Rework to remove duplication and move the shift==0 check earlier.
mdickinson cf7de3b
Update NEWS.d entry
mdickinson 41de654
Revert unrelated spacing change
mdickinson 27843b1
Fix unidiomatic decrement
mdickinson 53a4e24
Don't handle the shift==0 special-case until we need to
mdickinson b3a1a8f
Fix incompatible types
mdickinson fd4ce81
Comment updates
mdickinson 447e508
Updates from review
mdickinson 1bf4063
Clean up loop declarations
mdickinson cfe47ac
Fix comment
mdickinson 68e10a3
Remove an unnecessary 'else' branch
mdickinson 5d8d8ef
New news entry
mdickinson c5e3f81
Merge remote-tracking branch 'upstream/main' into faster-rshift-of-ne…
mdickinson 82c5ccd
One more assert
mdickinson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Core and Builtins/2022-04-12-09-40-57.gh-issue-46055.IPb1HA.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Speed up right shift of negative integers, by removing unnecessary creation | ||
of temporaries. Original patch by Xinhang Xu, reworked by Mark Dickinson. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.