bpo-46039: Split yield from in two #30035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpereira
reviewed
Dec 10, 2021
lpereira
reviewed
Dec 10, 2021
| static int | ||
| compiler_add_yield_from(struct compiler *c) | ||
| { | ||
| basicblock *start, *jump, *exit; |
There was a problem hiding this comment.
Would be nice if exit had another name, as this shadows the exit() function
iritkatriel
reviewed
Dec 10, 2021
markshannon
added
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit ec9dd28 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits
YIELD_FROMintoSENDandJUMP_ABSOLUTE. This is part of our push to make all operations explicit in the bytecode for instrumentation and optimization.This is a partial implementation of bpo-46039.
It does not do the threeway split described in issue, nor use zero-cost exception handling to replace the special case case in gen.throw().
https://bugs.python.org/issue46039