Skip to content

bpo-45898: Remove duplicate symbols from _ctypes/cfield.c (GH-29791) #29791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 24, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 26, 2021

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue45898

@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 26, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit 2a3424d7b8ef485a0df2589f54073e7e0f009ce3 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 26, 2021
@brettcannon
Copy link
Member

Looks like Windows still wants those symbols exported.

https://github.com/python/cpython/runs/4332435157?check_suite_focus=true#step:4:724

@arhadthedev
Copy link
Member

@brettcannon Is there libffi-8.dll in $(ExternalsDir)libffi-3.4.2 runner directory when a GitHub action fails (as declared in libffi.props)? I cannot say "the library is present because other imports are resolved" since ffi_type_* look like the only ffi exports. At least there is no other declaration with FFI_EXTERN in headers before generation.

@brettcannon
Copy link
Member

@brettcannon Is there libffi-8.dll in $(ExternalsDir)libffi-3.4.2 runner directory when a GitHub action fails (as declared in libffi.props)?

No idea.

@tiran
Copy link
Member Author

tiran commented Nov 27, 2021

Steve explained the issue on BPO. Windows cannot statically reference values from a DLL.

@tiran tiran requested a review from a team as a code owner November 27, 2021 20:28
@tiran tiran force-pushed the bpo-45898-cfield branch 2 times, most recently from 546cb9c to 69b2aa6 Compare November 28, 2021 09:24
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 20, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit 6787c5c 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 20, 2022
@tiran
Copy link
Member Author

tiran commented Feb 21, 2022

ARM64 buildbot is failing with LINK : fatal error LNK1123: failure during conversion to COFF: file invalid or corrupt, https://buildbot.python.org/all/#/builders/739/builds/265

@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 21, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit 6787c5c 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 21, 2022
@tiran tiran changed the title bpo-45898: Remove duplicate symbols from _ctypes/cfield.c bpo-45898: Remove duplicate symbols from _ctypes/cfield.c (GH-29791) Feb 24, 2022
@tiran tiran merged commit 38f331d into python:main Feb 24, 2022
@tiran tiran deleted the bpo-45898-cfield branch February 24, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants