bpo-44353: Correct docstring for NewType
#29785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docstring for `typing.NewType` is no longer strictly accurate, now that `NewType` is a class, rather than a function
AlexWaygood
requested review from
Fidget-Spinner and
gvanrossum
as code owners
AlexWaygood
changed the title
NewTypeNewType
JelleZijlstra
approved these changes
Nov 26, 2021
|
@gvanrossum: Please replace |
|
Sorry to bother you @gvanrossum — could this possibly be backported to 3.10 as well? 🙂 |
|
Thanks @AlexWaygood for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Sorry @AlexWaygood and @gvanrossum, I had trouble checking out the |
Fidget-Spinner
added
needs backport to 3.10
|
Thanks @AlexWaygood for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 26, 2021
The docstring for `typing.NewType` is no longer strictly accurate, now that `NewType` is a class, rather than a function (cherry picked from commit 93c65df) Co-authored-by: Alex Waygood <[email protected]>
|
GH-29796 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Nov 26, 2021
The docstring for `typing.NewType` is no longer strictly accurate, now that `NewType` is a class, rather than a function (cherry picked from commit 93c65df) Co-authored-by: Alex Waygood <[email protected]>
|
Thanks @Fidget-Spinner! |
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
The docstring for `typing.NewType` is no longer strictly accurate, now that `NewType` is a class, rather than a function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docstring for
typing.NewTypeis no longer strictly accurate, now thatNewTypeis a class, rather than a functionhttps://bugs.python.org/issue44353