Skip to content

bpo-45820: Fix a segfault when the parser fails without reading any input #29580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Nov 16, 2021

@pablogsal pablogsal merged commit df4ae55 into python:main Nov 16, 2021
@pablogsal pablogsal deleted the bpo-45820 branch November 16, 2021 19:51
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 16, 2021
…nput (pythonGH-29580)

(cherry picked from commit df4ae55)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@bedevere-bot
Copy link

GH-29583 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 16, 2021
@bedevere-bot
Copy link

GH-29584 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 16, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 16, 2021
…nput (pythonGH-29580)

(cherry picked from commit df4ae55)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
miss-islington added a commit that referenced this pull request Nov 17, 2021
…nput (GH-29580)

(cherry picked from commit df4ae55)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.10 has failed when building commit b455df5.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/724/builds/135) and take a look at the build logs.
  4. Check if the failure is related to this commit (b455df5) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/724/builds/135

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

407 tests OK.

10 slowest tests:

  • test_concurrent_futures: 3 min 34 sec
  • test_multiprocessing_spawn: 2 min 33 sec
  • test_multiprocessing_forkserver: 1 min 49 sec
  • test_unparse: 1 min 32 sec
  • test_asyncio: 1 min 21 sec
  • test_tokenize: 1 min 11 sec
  • test_lib2to3: 1 min 4 sec
  • test_logging: 58.0 sec
  • test_capi: 54.3 sec
  • test_ssl: 48.8 sec

1 test altered the execution environment:
test_ftplib

16 tests skipped:
test_devpoll test_epoll test_gdb test_ioctl test_msilib
test_multiprocessing_fork test_ossaudiodev test_spwd
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 8 min 40 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_c6bb30e5'


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_d292748e'


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 1009, in _bootstrap_inner
    self.run()
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 298, in run
    asyncore.loop(timeout=0.1, count=1)
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 214, in loop
    poll_fun(timeout, map)
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 157, in poll
    read(obj)
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 94, in read
    obj.handle_error()
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 421, in handle_error
    raise Exception
Exception


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 90, in read
    obj.handle_read_event()
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 384, in handle_read_event
    self._do_ssl_handshake()
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 345, in _do_ssl_handshake
    self.socket.do_handshake()
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/ssl.py", line 1341, in do_handshake
    self._sslobj.do_handshake()
ssl.SSLZeroReturnError: TLS/SSL connection has been closed (EOF) (_ssl.c:997)

ambv added a commit that referenced this pull request Nov 18, 2021
… any input (GH-29580) (GH-29584)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants