Skip to content

bpo-45759: Better error messages for non-matching 'elif'/'else' state… #29481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 82 commits into from
Closed

bpo-45759: Better error messages for non-matching 'elif'/'else' state… #29481

wants to merge 82 commits into from

Conversation

thatbirdguythatuknownot
Copy link
Contributor

@thatbirdguythatuknownot thatbirdguythatuknownot commented Nov 9, 2021 •
edited
Loading

thatbirdguythatuknownot and others added 20 commits November 9, 2021 08:07
@thatbirdguythatuknownot
bpo-45759: Better error messages for no-match 'elif'/'else' statements (
82120eb 
pythonGH-29481)
@blurb-it
📜🤖 Added by blurb_it.
a349649
@thatbirdguythatuknownot
bpo-45759: Better error messages for non-matching 'elif'/'else' state…
d5fbe1d 
…ments
@thatbirdguythatuknownot
bpo-45759: Better error messages for non-matching 'elif'/'else' state…
f1b3b92 
…ments (pythonGH-29481)
@thatbirdguythatuknownot
bpo-45759: Better error messages for non-matching 'elif'/'else' state…
c9a9df4 
…ments (pythonGH-29481)
@thatbirdguythatuknownot
bpo-45759: Better error messages for non-matching 'elif'/'else' state…
f7f1f52 
…ments (pythonGH-29481)
@thatbirdguythatuknownot
bpo-45759: Better error messages for non-matching 'elif'/'else' state…
a03f389 
…ments (pythonGH-29481)
@thatbirdguythatuknownot
bpo-45759: Better error messages for non-matching 'elif'/'else' state…
7b8eaa9 
…ments (pythonGH-29481)
@thatbirdguythatuknownot
bpo-45759: Better error messages for non-matching 'elif'/'else' state…
8482969 
…ments (pythonGH-29481)
@thatbirdguythatuknownot
bpo-45759: Better error messages for non-matching 'elif'/'else' state…
14c7059 
…ments (pythonGH-29481)
@thatbirdguythatuknownot
bpo-45759: Better error messages for non-matching 'elif'/'else' state…
c663336 
…ments (pythonGH-29481)
@thatbirdguythatuknownot
bpo-45759: Better error messages for non-matching 'elif'/'else' state…
2347abf 
…ments (pythonGH-29481)
@thatbirdguythatuknownot
Update 2021-11-09-00-08-55.bpo-45759.ji7j-W.rst
92d6323
@thatbirdguythatuknownot
bpo-45759: Better error messages for non-matching 'elif'/'else' state…
3df6948 
…ments (pythonGH-29481)
@thatbirdguythatuknownot
bpo-45759: Better error messages for non-matching 'elif'/'else' state…
16032ba 
…ment (pythonGH-29481)
@thatbirdguythatuknownot
bpo-45759: Better error messages for non-matching 'elif'/'else' state…
c7c6b71 
…ments (pythonGH-29481)
@thatbirdguythatuknownot
bpo-45759: Better error messages for non-matching 'elif'/'else' state…
d9f207f 
…ments (pythonGH-29481)
@thatbirdguythatuknownot
bpo-45759: Better error messages for non-matching 'elif'/'else' state…
8868bcd 
…ments (pythonGH-29481)
@thatbirdguythatuknownot
bpo-45759: Better error messages for non-matching 'elif'/'else' state…
6a710ad 
…ments (pythonGH-29481)
@thatbirdguythatuknownot
bpo-45759: Better error messages for non-matching 'elif'/'else' state…
7c12736 
…ments (pythonGH-29481)
pablogsal
pablogsal requested changes Nov 9, 2021
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! We need to think about this a bit more because I am not fully sure if this error is common enough to justify the extra complexity.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

pablogsal
pablogsal reviewed Nov 9, 2021
View reviewed changes
@thatbirdguythatuknownot
Copy link
Contributor Author

Sorry for the many 'Fix conflicts' commits, I was trying to fix the Parser/parser.c conflict.

@thatbirdguythatuknownot thatbirdguythatuknownot requested review from pablogsal and removed request for a team November 10, 2021 00:25
@thatbirdguythatuknownot
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

@thatbirdguythatuknownot
Copy link
Contributor Author

Moved to another pull request with same title.

@thatbirdguythatuknownot thatbirdguythatuknownot mannequin mentioned this pull request Apr 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees
No one assigned
Labels
awaiting change review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thatbirdguythatuknownot @bedevere-bot @pablogsal @the-knights-who-say-ni