Skip to content

bpo-45648: Add checks for tp_version_tag in specialize.c #29272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Oct 28, 2021

@Fidget-Spinner Fidget-Spinner changed the title Add checks for tp_version_tag in specialize.c bpo-45648: Add checks for tp_version_tag in specialize.c Oct 28, 2021
@Fidget-Spinner
Copy link
Member Author

I'm skipping news because this shouldn't have any visibility to end users. It's extremely hard to achieve this (though not as hard as exhausting the old ma_version_tag).

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Nov 28, 2021
@Fidget-Spinner Fidget-Spinner removed the stale Stale PR or inactive for long period of time. label Dec 15, 2021
@kumaraditya303
Copy link
Contributor

@Fidget-Spinner Is this still relevant as it has merge conflicts ?

@Fidget-Spinner
Copy link
Member Author

@kumaraditya303 it's still relevant. If you want to take over, go ahead. A simple solution like Mark suggested is to just check tp_version_tag == 0 after every analyze_descriptor call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants