Skip to content

[3.6] bpo-30845: Enhance test_concurrent_futures cleanup (#2564) #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2017
Merged

[3.6] bpo-30845: Enhance test_concurrent_futures cleanup (#2564) #2880

merged 1 commit into from
Jul 26, 2017

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jul 26, 2017

  • bpo-30845: reap_children() now logs warnings

  • bpo-30845: Enhance test_concurrent_futures cleanup

In setUp() and tearDown() methods of test_concurrent_futures tests,
make sure that tests don't leak threads nor processes. Clear
explicitly the reference to the executor to make it that it's
destroyed (to prevent "dangling threads" warning).

(cherry picked from commit 3df9dec)

https://bugs.python.org/issue30845

* bpo-30845: reap_children() now logs warnings

* bpo-30845: Enhance test_concurrent_futures cleanup

In setUp() and tearDown() methods of test_concurrent_futures tests,
make sure that tests don't leak threads nor processes. Clear
explicitly the reference to the executor to make it that it's
destroyed (to prevent "dangling threads" warning).

(cherry picked from commit 3df9dec)
@vstinner vstinner merged commit a6f0452 into python:3.6 Jul 26, 2017
@vstinner vstinner deleted the futures36 branch July 26, 2017 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants