bpo-45238: Fix unittest.IsolatedAsyncioTestCase.debug() #28449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It runs now asynchronous methods and callbacks. If it fails, doCleanups() can be called for cleaning up.
serhiy-storchaka
added
type-bug
asvetlov
approved these changes
Sep 20, 2021
Comment on lines
+170
to
+172
| def __del__(self): | ||
| if self._asyncioTestLoop is not None: | ||
| self._tearDownAsyncioLoop() |
There was a problem hiding this comment.
Looks a little weird but I don't have better idea.
There was a problem hiding this comment.
Yes, it looks very weird. And you should ensure that the IsolatedAsyncioTestCase instance is destroyed before any other event loop is run, otherwise you can get an ugly message on the stderr during garbage collecting.
ambv
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
ambv
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
|
Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
Sorry @serhiy-storchaka and @ambv, I had trouble checking out the |
|
Sorry, @serhiy-storchaka and @ambv, I could not cleanly backport this to |
ambv
added
needs backport to 3.10
|
Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Sorry @serhiy-storchaka and @ambv, I had trouble checking out the |
|
whyyy |
ambv
pushed a commit
to ambv/cpython
that referenced
this pull request
Sep 22, 2021
…nGH-28449) It runs now asynchronous methods and callbacks. If it fails, doCleanups() can be called for cleaning up. (cherry picked from commit ecb6922) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-28521 is a backport of this pull request to the 3.10 branch. |
ambv
pushed a commit
to ambv/cpython
that referenced
this pull request
Sep 22, 2021
…GH-28449) It runs now asynchronous methods and callbacks. If it fails, doCleanups() can be called for cleaning up.. (cherry picked from commit ecb6922) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-28522 is a backport of this pull request to the 3.9 branch. |
ambv
added a commit
that referenced
this pull request
Sep 22, 2021
) (GH-28521) It runs now asynchronous methods and callbacks. If it fails, doCleanups() can be called for cleaning up. (cherry picked from commit ecb6922) Co-authored-by: Serhiy Storchaka <[email protected]>
ambv
added a commit
that referenced
this pull request
Sep 22, 2021
…) (GH-28522) It runs now asynchronous methods and callbacks. If it fails, doCleanups() can be called for cleaning up.. (cherry picked from commit ecb6922) Co-authored-by: Serhiy Storchaka <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It runs now asynchronous methods and callbacks.
If it fails, doCleanups() can be called for cleaning up.
https://bugs.python.org/issue45238