bpo-45019: Silence a warning in test_ctypes. #28362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
approved these changes
Sep 15, 2021
Lib/ctypes/test/test_values.py
Outdated
Comment on lines
76
to
78
| # Hide the message written by the __hello__ module. | ||
| with captured_stdout(): | ||
| spec = importlib.util.find_spec(modname) |
There was a problem hiding this comment.
I'm wondering if it wouldn't be useful to just not print anything from the __hello__ module unless it's invoked as a __main__ module? That could possibly allow us to remove a lot of captured_stdout() calls. What is this output actually needed for (other than tradition)?
There was a problem hiding this comment.
I'm sure we didn't think about it when the module was added.
gvanrossum
reviewed
Sep 15, 2021
Lib/ctypes/test/test_values.py
Outdated
| @@ -73,6 +73,7 @@ class struct_frozen(Structure): | |||
| self.assertTrue([entry.code[i] for i in range(abs(entry.size))]) | |||
| # Check the module's package-ness. | |||
| with import_helper.frozen_modules(): | |||
| # Hide the message written by the __hello__ module. | |||
gvanrossum
approved these changes
Sep 15, 2021
|
I'm going to move the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed in PR gh-28319.
https://bugs.python.org/issue45019