Skip to content

bpo-45017: move opcode-related logic from modulefinder to dis #28246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 9, 2021
Merged

bpo-45017: move opcode-related logic from modulefinder to dis #28246

merged 5 commits into from
Sep 9, 2021

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Sep 8, 2021 •
edited by bedevere-bot
Loading

1st1
1st1 reviewed Sep 8, 2021
View reviewed changes
1st1
1st1 reviewed Sep 8, 2021
View reviewed changes
1st1
1st1 approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not the code owner here but the refactoring looks ok to me.

@iritkatriel iritkatriel merged commit 04676b6 into python:main Sep 9, 2021
@iritkatriel iritkatriel deleted the bpo-45017 branch November 5, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

@markshannon markshannon Awaiting requested review from markshannon

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@isidentical isidentical Awaiting requested review from isidentical

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iritkatriel @1st1 @the-knights-who-say-ni @bedevere-bot