Skip to content

bpo-44991: Normalise sqlite3 function and collation callback naming #28209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2021
Merged

bpo-44991: Normalise sqlite3 function and collation callback naming #28209

merged 1 commit into from
Oct 12, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Sep 7, 2021 •
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
Contributor Author

I forgot these two in GH-28088.

@erlend-aasland
Copy link
Contributor Author

cc. @encukou

@erlend-aasland erlend-aasland changed the title bpo-44991: Normalise function and collation callback naming bpo-44991: Normalise sqlite3 function and collation callback naming Sep 7, 2021
@erlend-aasland erlend-aasland reopened this Sep 7, 2021
@erlend-aasland
Copy link
Contributor Author

Reopening to trigger asan test again.

shihai1991
shihai1991 approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@shihai1991 shihai1991 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping consistent code style is fine to me.

@erlend-aasland
Copy link
Contributor Author

Keeping consistent code style is fine to me.

Thanks for reviewing!

@github-actions
Copy link

github-actions bot commented Oct 8, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Oct 8, 2021
encukou
encukou reviewed Oct 12, 2021
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't care that strongly about the pysqlite prefix, so I didn't point this out in the earlier review.
But sure, let's make them consistent!

@encukou encukou merged commit cfb1df3 into python:main Oct 12, 2021
@erlend-aasland erlend-aasland deleted the sqlite-normalise-func branch October 12, 2021 11:39
@erlend-aasland erlend-aasland mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou left review comments

@shihai1991 shihai1991 shihai1991 approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
skip news stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @encukou @shihai1991 @the-knights-who-say-ni @bedevere-bot