bpo-38291: Update 3.10 WhatsNew with typing.{io|re} DeprecationWarning #27872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srittau can I trouble you for a review please? It concerns your work :). |
Fidget-Spinner
changed the title
| @@ -1401,6 +1401,13 @@ subclasses with the :func:`runtime_checkable` decorator | |||
| if they want runtime protocols. | |||
| (Contributed by Yurii Karabas in :issue:`38908`) | |||
|
|
|||
| Importing from the ``typing.io`` and ``typing.re`` submodules will now emit | |||
There was a problem hiding this comment.
It is worth to add it in the "Deprecated" section below.
There was a problem hiding this comment.
Initially I thought no because What's new in 3.8 should have it https://docs.python.org/3/whatsnew/3.8.html#deprecated, but surprisingly it doesn't. So yep we should add it as a proper reminder this time.
|
Thanks @Fidget-Spinner for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-27907 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 23, 2021
pythonGH-27872) (cherry picked from commit 1a995b0) Co-authored-by: Ken Jin <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Aug 23, 2021
GH-27872) (cherry picked from commit 1a995b0) Co-authored-by: Ken Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue38291