bpo-44717: refactor _PyModuleSpec helpers #27344
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filipe Laíns <[email protected]>
|
This PR is stale because it has been open for 30 days with no activity. |
|
Closing this as there doesn't seem to be enough interest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
_PyModuleSpec_IsInitializing, as suggested in #26822, and adds the exception cleaning side effect to_PyModuleSpec_IsUninitializedSubmodule. The exception cleaning is not really needed in_PyModuleSpec_IsUninitializedSubmoduleas we are using it, but it makes the code too fragile, so I think it would be best to align it with_PyModuleSpec_IsInitializing, this was an oversight of the initial implementation. Btw, sorry for all of the back and forward on this bpo 😕https://bugs.python.org/issue44717