Skip to content

bpo-44441: _PyImport_Fini2() resets PyImport_Inittab #26874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2021
Merged

bpo-44441: _PyImport_Fini2() resets PyImport_Inittab #26874

merged 1 commit into from
Jun 23, 2021

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 23, 2021 •
edited by bedevere-bot
Loading

Py_RunMain() now resets PyImport_Inittab to its initial value at
exit. It must be possible to call PyImport_AppendInittab() or
PyImport_ExtendInittab() at each Python initialization.

https://bugs.python.org/issue44441

@vstinner
bpo-44441: _PyImport_Fini2() resets PyImport_Inittab
3ea3348 
Py_RunMain() now resets PyImport_Inittab to its initial value at
exit. It must be possible to call PyImport_AppendInittab() or
PyImport_ExtendInittab() at each Python initialization.
@vstinner
Copy link
Member Author

vstinner commented Jun 23, 2021 •
edited
Loading

test_ssl failure on macOS is known and unrelated: https://bugs.python.org/issue44237

@vstinner vstinner merged commit 489699c into python:main Jun 23, 2021
@vstinner vstinner deleted the inittab branch June 23, 2021 12:13
@vstinner vstinner added the needs backport to 3.10 only security fixes label Jun 23, 2021
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 489699ca05bed5cfd10e847d8580840812b476cd 3.10

@bedevere-bot
Copy link

GH-26877 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 23, 2021
vstinner added a commit that referenced this pull request Jun 23, 2021
@vstinner
bpo-44441: _PyImport_Fini2() resets PyImport_Inittab (GH-26874) (GH-2…
5ed7827 
…6878)

Py_RunMain() now resets PyImport_Inittab to its initial value at
exit. It must be possible to call PyImport_AppendInittab() or
PyImport_ExtendInittab() at each Python initialization.

(cherry picked from commit 489699c)
vstinner added a commit that referenced this pull request Jun 23, 2021
@vstinner
bpo-44441: _PyImport_Fini2() resets PyImport_Inittab (GH-26874) (GH-2…
ece3841 
…6877)

Py_RunMain() now resets PyImport_Inittab to its initial value at
exit. It must be possible to call PyImport_AppendInittab() or
PyImport_ExtendInittab() at each Python initialization.

(cherry picked from commit 489699c)
@vstinner vstinner mentioned this pull request Jun 23, 2021
Closed
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

@vstinner vstinner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni