Skip to content

bpo-38291: Reset DeprecationWarning filters in test_typing io and re #26811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Jun 20, 2021

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Jun 20, 2021
@Fidget-Spinner Fidget-Spinner marked this pull request as draft June 20, 2021 17:27
@Fidget-Spinner Fidget-Spinner changed the title Reset DeprecationWarning filters in test_typing io and re bpo-38291: Reset DeprecationWarning filters in test_typing io and re Jun 20, 2021
@Fidget-Spinner Fidget-Spinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 20, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @Fidget-Spinner for commit 5190297 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 20, 2021
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we went too quick here? I’m not sure what this does (it’s been a long time since I played with warnings) but if this is blocking other PRs I am happy to merge it.

@Fidget-Spinner Fidget-Spinner marked this pull request as ready for review June 21, 2021 10:02
@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented Jun 21, 2021

I suppose we went too quick here? I’m not sure what this does (it’s been a long time since I played with warnings) but if this is blocking other PRs I am happy to merge it.

Luckily this isn't blocking other PRs, buildbot failures only block releases AFAIK. As Sebastian mentioned on the bpo issue, it's an Azure pipelines problem. The specific pipeline is only run after a commit is made. Even with the test-with-buildbots label, I'm unable to recreate the conditions for the failure on a PR. At best, this fix is a hunch which I have no way of verifying or reproducing locally.

This fix wasn't clear to me too, until I read this part of the warnings docs:
https://docs.python.org/3/library/warnings.html#testing-warnings

@gvanrossum gvanrossum merged commit c5d700f into python:main Jun 21, 2021
@bedevere-bot
Copy link

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@Fidget-Spinner Fidget-Spinner deleted the fix-azure-appx branch June 22, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants