bpo-33433 Fix private address checking for IPv4 mapped IPv6. #26172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpshead
added
needs backport to 3.10
gpshead
approved these changes
May 17, 2021
|
@JamoBox: Status check is done, and it's a failure ❌ . |
|
@JamoBox: Status check is done, and it's a success ✅ . |
|
Thanks @JamoBox for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-26189 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 17, 2021
…H-26172) For IPv4 mapped IPv6 addresses, defer privacy check to the mapped IPv4 address. Solves bug where public mapped IPv4 addresses are considered private by the IPv6 check. Automerge-Triggered-By: GH:gpshead (cherry picked from commit 83f0f8d) Co-authored-by: Pete Wicken <[email protected]>
miss-islington
added a commit
that referenced
this pull request
May 17, 2021
For IPv4 mapped IPv6 addresses, defer privacy check to the mapped IPv4 address. Solves bug where public mapped IPv4 addresses are considered private by the IPv6 check. Automerge-Triggered-By: GH:gpshead (cherry picked from commit 83f0f8d) Co-authored-by: Pete Wicken <[email protected]>
|
Thanks Gregory! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For IPv4 mapped IPv6 addresses, defer privacy check to the mapped IPv4 address. Solves bug where public mapped IPv4 addresses are considered private by the IPv6 check.
https://bugs.python.org/issue33433
Automerge-Triggered-By: GH:gpshead