bpo-43916: Apply Py_TPFLAGS_DISALLOW_INSTANTIATION to selected types #25748
Conversation
|
cc. @vstinner, @pablogsal |
erlend-aasland
force-pushed
the
add-disallow-instantiation-flag
branch
from
2ef1370 to
71439d0
Compare
|
I took the liberty to open this issue to fix the rest of the affected types. From my understanding of Pablo's and Serhiy's comments in the issue, it was desired that all of the affected types should be fixed, and regression tests added if possible. |
| tp = type(iter(array.array('I'))) | ||
| self.assertRaises(TypeError, tp) |
There was a problem hiding this comment.
If it would expect, the constructor would expect an argument:
| tp = type(iter(array.array('I'))) | |
| self.assertRaises(TypeError, tp) | |
| my_array = array.array('I') | |
| arrayiterator = type(iter(my_array)) | |
| self.assertRaises(TypeError, arrayiterator, my_array) |
There was a problem hiding this comment.
Hm, I don't think so.
$ python3.10
>>> import array
>>> tp = type(iter(array.array('I')))
>>> tp()
<array.arrayiterator object at 0x10f934140>
>>> tp([])
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: array.arrayiterator() takes no arguments
>>>
There was a problem hiding this comment.
Ditto for the similar suggestions.
There was a problem hiding this comment.
On what do you want to iterate if there is no argument?
Obviously, today, it takes no argument... because the type doesn't implement tp_new nor tp_init ;-)
There was a problem hiding this comment.
Does it really have anything to say? We hit the right exception anyway, AFAICS.
$ ./python.exe
Python 3.10.0a7+ (heads/add-disallow-instantiation-flag:71439d0de8, Apr 30 2021, 15:22:20) [Clang 12.0.5 (clang-1205.0.22.9)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import array
>>> tp = type(iter(array.array('I')))
>>> tp()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: cannot create 'array.arrayiterator' instances
>>> tp([])
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: cannot create 'array.arrayiterator' instances
There was a problem hiding this comment.
My concern can be addressed later by adding an helper function which checks the error message.
There was a problem hiding this comment.
I insist on this issue because test_sys had a test which still passed when I modified sys.flags type to allow instantiation. I had to fix the test: 3bb0994
There was a problem hiding this comment.
Ah, I got it now. I misunderstood you first. Yes, that makes sense. We'll fix it when we've got a helper in place.
| @@ -1046,6 +1046,7 @@ def __del__(self): | |||
| panel.set_userptr(A()) | |||
| panel.set_userptr(None) | |||
|
|
|||
| @cpython_only | |||
| @requires_curses_func('panel') | |||
| def test_new_curses_panel(self): | |||
| w = curses.newwin(10, 10) | |||
There was a problem hiding this comment.
I also guess that the constructor would expect an argument:
self.assertRaises(TypeError, type(panel), w)
| # Prevent heap types from being created uninitialised (bpo-43916) | ||
| self.g = gdbm.open(filename, 'c') | ||
| tp = type(self.g) | ||
| self.assertRaises(TypeError, tp) |
There was a problem hiding this comment.
| self.assertRaises(TypeError, tp) | |
| self.assertRaises(TypeError, tp, filename, 'c') |
| def test_uninitialised_new(self): | ||
| # Prevent heap types from being created uninitialised (bpo-43916) | ||
| tp = type(c_functools.cmp_to_key(None)) | ||
| self.assertRaises(TypeError, tp) |
There was a problem hiding this comment.
| self.assertRaises(TypeError, tp) | |
| self.assertRaises(TypeError, tp, None) |
| self.assertRaises(TypeError, re.Pattern) | ||
| pat = re.compile("") | ||
| tp = type(pat.scanner("")) | ||
| self.assertRaises(TypeError, tp) |
There was a problem hiding this comment.
| self.assertRaises(TypeError, tp) | |
| self.assertRaises(TypeError, tp, "") |
https://bugs.python.org/issue43916