bpo-43772: fix TypeVar.__ror__ #25339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+188
to
+189
| self.assertEqual(X | "x", Union[X, "x"]) | ||
| self.assertEqual("x" | X, Union["x", X]) |
There was a problem hiding this comment.
I don't think these are testing for what Larry meant, Union comparisons are order independent, so
>>> T | "x" == "x" | T
True
>>> T | "x" == Union["x" | T]
TrueAnd the current test should pass even without the patch.
What he meant is that the repr is order dependent, so the test should be something like:
Suggested change
| self.assertEqual(X | "x", Union[X, "x"]) | |
| self.assertEqual("x" | X, Union["x", X]) | |
| self.assertEqual(repr(X | int), "typing.Union[~X, int]") | |
| self.assertEqual(repr(int | X), "typing.Union[int, ~X]") |
Which currently fails without the patch:
>>> repr(T | int)
"typing.Union[~T, int]"
>>> repr(int | T)
"typing.Union[int, ~T]"There was a problem hiding this comment.
Good point, I should have written the test first to make sure I was actually fixing anything.
There was a problem hiding this comment.
Made it use get_args() to test though, which feels cleaner than testing the repr() directly.
There was a problem hiding this comment.
Yeah I think that works :). The __repr__ is dependent on __args__ after all.
larryhastings
approved these changes
Apr 11, 2021
gvanrossum
approved these changes
Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very simple change.
https://bugs.python.org/issue43772