Skip to content

bpo-39231: Correct tutorial annotations section #25029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2021

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Mar 26, 2021

@terryjreedy terryjreedy changed the title bpo-39231: doc: correction in annotations tutorial bpo-39231: correct tutorial annotations section Mar 27, 2021
@terryjreedy terryjreedy changed the title bpo-39231: correct tutorial annotations section bpo-39231: Correct tutorial annotations section Mar 27, 2021
@terryjreedy terryjreedy merged commit a53e9a7 into python:master Mar 27, 2021
@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-25042 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Mar 27, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2021
(cherry picked from commit a53e9a7)

Co-authored-by: Irit Katriel <[email protected]>
@bedevere-bot
Copy link

GH-25043 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2021
(cherry picked from commit a53e9a7)

Co-authored-by: Irit Katriel <[email protected]>
miss-islington added a commit that referenced this pull request Mar 27, 2021
(cherry picked from commit a53e9a7)

Co-authored-by: Irit Katriel <[email protected]>
miss-islington added a commit that referenced this pull request Mar 27, 2021
(cherry picked from commit a53e9a7)

Co-authored-by: Irit Katriel <[email protected]>
@terryjreedy
Copy link
Member

Ken, though you review was minimal, it did serve as a ping that got me to look and and finish this.

@Fidget-Spinner
Copy link
Member

Ken, though you review was minimal, it did serve as a ping that got me to look and and finish this.

I'm glad to hear it helped you in some way.

Also, much thanks to Irit for resurfacing this 1 year old issue and sending the PR for it.

@iritkatriel iritkatriel deleted the bpo-39231 branch August 2, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants