Skip to content

bpo-43225: [DOC] Add missing value returned by methods on cookiejar #24522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 15, 2021
Merged

bpo-43225: [DOC] Add missing value returned by methods on cookiejar #24522

merged 3 commits into from
Nov 15, 2021

Conversation

eamanu
Copy link
Contributor

@eamanu eamanu commented Feb 13, 2021 •
edited by bedevere-bot
Loading

Documentation say that return something but don't specific with what
value is return, and that can be confuse. This patch add that information.

https://bugs.python.org/issue43225

@eamanu
Add missing value returned by methods on cookiejar
8abb3c7 
Documentation say that return something but don't specific with what
value is return, and that can be confuse. This patch add that information.
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 13, 2021
@eamanu eamanu closed this Feb 14, 2021
@eamanu eamanu reopened this Feb 14, 2021
@eamanu
Copy link
Contributor Author

eamanu commented Feb 14, 2021

Re open to know if the tests pass

@eamanu eamanu changed the title [DOC] Add missing value returned by methods on cookiejar bpo-43225: [DOC] Add missing value returned by methods on cookiejar Feb 14, 2021
@eamanu eamanu mentioned this pull request Feb 18, 2021
Merged
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 17, 2021
akulakov
akulakov requested changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@akulakov akulakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!, - this is a good change that makes return value much clearer. Requesting a small change because 'whether' would not be gramatically correct to leave in with this change.

eamanu and others added 2 commits July 7, 2021 12:51
@eamanu
Copy link
Contributor Author

eamanu commented Jul 7, 2021

Thanks @akulakov

@willingc willingc merged commit 3352834 into python:main Nov 15, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@eamanu @akulakov @remykarem
bpo-43225: [DOC] Add missing value returned by methods on cookiejar (p…
e535c71 
…ythonGH-24522)

* Add missing value returned by methods on cookiejar

Documentation say that return something but don't specific with what
value is return, and that can be confuse. This patch add that information.

* Update Doc/library/http.cookiejar.rst

Co-authored-by: andrei kulakov <[email protected]>

* Update Doc/library/http.cookiejar.rst

Co-authored-by: andrei kulakov <[email protected]>

Co-authored-by: andrei kulakov <[email protected]>
@eamanu eamanu mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akulakov akulakov akulakov requested changes

@willingc willingc willingc approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eamanu @akulakov @willingc @the-knights-who-say-ni @bedevere-bot