bpo-31904: add library search path by wr-cc in add_cross_compiling_paths() #24191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Jan 18, 2021
|
LGTM, thanks for the updates. I'm not fully comfortable with this PR which is maybe a little bit too specific to "clang --print-search-dirs" on Windows using MSYS. It's only used on VxWorks and only for cross-compilation. It's a little bit annoying to have to accumulate such code in setup.py to support different toolchains, but I don't see a better option for now. distutils is not great for cross-compiling, and right now setup.py is implemented with distutils build_ext and Extension classes. I doubt that setuptools will have a better support for cross-compilation soon. In the meanwhile, setup.py is the right place for such code. |
|
I rewrote the commit title to better summarize what it does. Thanks @pxinwr, I merged your PR. |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Add library search path by wr-cc in add_cross_compiling_paths().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VxWorks has a compiler driver utility called wr-cc which wraps gcc or clang compiler. The call of sysconfig.get_config_var('CC') on building machine returns "wr-cc" for VxWorks cross compiling. "wr-cc --print-search-dirs" will add VSB specific path for library searching. Building extension modules will need these paths. So adding them in add_cross_compiling_paths().
https://bugs.python.org/issue31904