Skip to content

bpo-42728: Fixes a typo in importlib.metadata. #23921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2020
Merged

bpo-42728: Fixes a typo in importlib.metadata. #23921

merged 1 commit into from
Dec 31, 2020

Conversation

sighingnow
Copy link
Contributor

@sighingnow sighingnow commented Dec 24, 2020 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@sighingnow

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 24, 2020
@sighingnow
Copy link
Contributor Author

Could anybody help me to get this PR merged?

warsaw
warsaw approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaraco - Does this same typo applies to the standalone version?

@warsaw warsaw merged commit 3631d6d into python:master Dec 31, 2020
@miss-islington
Copy link
Contributor

Thanks @sighingnow for the PR, and @warsaw for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@warsaw: Please replace # with GH- in the commit message next time. Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 31, 2020
@sighingnow @miss-islington
Fixes a typo in importlib.metadata. (pythonGH-23921)
5b16182 
Signed-off-by: Tao He <[email protected]>
(cherry picked from commit 3631d6d)

Co-authored-by: Tao He <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Dec 31, 2020
@bedevere-bot
Copy link

GH-24029 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 31, 2020
@sighingnow @miss-islington
Fixes a typo in importlib.metadata. (pythonGH-23921)
5cae8cf 
Signed-off-by: Tao He <[email protected]>
(cherry picked from commit 3631d6d)

Co-authored-by: Tao He <[email protected]>
@bedevere-bot
Copy link

GH-24030 is a backport of this pull request to the 3.8 branch.

warsaw pushed a commit that referenced this pull request Dec 31, 2020
@miss-islington @sighingnow
Fixes a typo in importlib.metadata. (GH-23921) (#24029)
55fadff 
Signed-off-by: Tao He <[email protected]>
(cherry picked from commit 3631d6d)

Co-authored-by: Tao He <[email protected]>

Co-authored-by: Tao He <[email protected]>
warsaw pushed a commit that referenced this pull request Dec 31, 2020
@miss-islington @sighingnow
Fixes a typo in importlib.metadata. (GH-23921) (#24030)
82f24ff 
Signed-off-by: Tao He <[email protected]>
(cherry picked from commit 3631d6d)

Co-authored-by: Tao He <[email protected]>

Co-authored-by: Tao He <[email protected]>
@sighingnow sighingnow deleted the ht/fix-doc branch January 7, 2021 17:16
@jaraco
Copy link
Member

jaraco commented Jan 15, 2021

@jaraco - Does this same typo applies to the standalone version?

Yes. Thanks for sharing.

I've committed the same change at python/importlib_metadata@bde4e15.

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@sighingnow @adorilson
Fixes a typo in importlib.metadata. (python#23921)
b076407 
Signed-off-by: Tao He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warsaw warsaw warsaw approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sighingnow @the-knights-who-say-ni @miss-islington @bedevere-bot @jaraco @warsaw @shihai1991