Skip to content

[3.9] bpo-42604: always set EXT_SUFFIX=${SOABI}${SHLIB_SUFFIX} when using configure (GH-23708) #23866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 20, 2020

Now all platforms use a value for the "EXT_SUFFIX" build variable derived
from SOABI (for instance in FreeBSD, "EXT_SUFFIX" is now ".cpython-310d.so"
instead of ".so"). Previously only Linux, Mac and VxWorks were using a value
for "EXT_SUFFIX" that included "SOABI".

Co-authored-by: Pablo Galindo [email protected]
(cherry picked from commit a44ce6c)

Co-authored-by: Matti Picus [email protected]

https://bugs.python.org/issue42604

…onfigure (pythonGH-23708)

Now all platforms use a value for the "EXT_SUFFIX" build variable derived
from SOABI (for instance in FreeBSD, "EXT_SUFFIX" is now ".cpython-310d.so"
instead of ".so"). Previously only Linux, Mac and VxWorks were using a value
for "EXT_SUFFIX" that included "SOABI".

Co-authored-by: Pablo Galindo <[email protected]>
(cherry picked from commit a44ce6c)

Co-authored-by: Matti Picus <[email protected]>
@miss-islington
Copy link
Contributor Author

@mattip and @pablogsal: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@mattip and @pablogsal: Status check is done, and it's a failure ❌ .

@mattip
Copy link
Contributor

mattip commented Dec 20, 2020

I don’t think this failure is connected to the change

======================================================================
FAIL: test_heading_callback (tkinter.test.test_ttk.test_widgets.TreeviewTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_widgets.py", line 1548, in test_heading_callback
    simulate_heading_click(5, 5)
  File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_widgets.py", line 1536, in simulate_heading_click
    self.assertEqual(self.tv.identify_region(x, y), 'heading')
AssertionError: 'nothing' != 'heading'
- nothing
+ heading


======================================================================
FAIL: test_variable_change (tkinter.test.test_ttk.test_extensions.LabeledScaleTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_extensions.py", line 144, in test_variable_change
    self.assertGreater(x.scale.coords()[0], curr_xcoord)
AssertionError: 1 not greater than 1

@pablogsal pablogsal merged commit 4b15596 into python:3.9 Dec 20, 2020
@miss-islington miss-islington deleted the backport-a44ce6c-3.9 branch December 20, 2020 04:54
@pablogsal
Copy link
Member

I don’t think this failure is connected to the change

======================================================================
FAIL: test_heading_callback (tkinter.test.test_ttk.test_widgets.TreeviewTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_widgets.py", line 1548, in test_heading_callback
    simulate_heading_click(5, 5)
  File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_widgets.py", line 1536, in simulate_heading_click
    self.assertEqual(self.tv.identify_region(x, y), 'heading')
AssertionError: 'nothing' != 'heading'
- nothing
+ heading


======================================================================
FAIL: test_variable_change (tkinter.test.test_ttk.test_extensions.LabeledScaleTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_extensions.py", line 144, in test_variable_change
    self.assertGreater(x.scale.coords()[0], curr_xcoord)
AssertionError: 1 not greater than 1

Yep, that is some unrelated tkinter failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants