bpo-24813: IDLE: Add bitness to About Idle title #2380
Conversation
|
@csabella, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mlouielu, @terryjreedy and @kbkaiser to be potential reviewers. |
Lib/idlelib/help_about.py
Outdated
|
|
||
| from tkinter import Toplevel, Frame, Label, Button, PhotoImage | ||
| from tkinter import SUNKEN, TOP, BOTTOM, LEFT, X, BOTH, W, EW, NSEW, E | ||
|
|
||
| from idlelib import textview | ||
|
|
||
|
|
||
| def _bitness(): |
Lib/idlelib/help_about.py
Outdated
| "Return bitness of platform." | ||
| bits, linkage = architecture() | ||
| if sys.platform == 'darwin': | ||
| bits = '64bit' if sys.maxsize > 2**32 else '32bit' |
There was a problem hiding this comment.
if sys.platform == 'darwin':
return '64' if sys.maxsize > 2**32 else '32'
else:
return architecture()[0][:2]
I guess I prefer multiple crisp returns to multiple assignments used to make a delayed return. I do understand the single exit idea from the Structured Programming revolution of the 1970s. 'Single exit' replaced multiple unrestricted GOTOs. A return is a very disciplined goto.
Since I have 64 bit installs and 32 bit clone debug builds, I tested and confirmed that the return on windows really is build bits and, in spite of the name, not physical architecture bits.
There was a problem hiding this comment.
concur with @terryjreedy 's method and name of the function
There was a problem hiding this comment.
Yes, this is much better, thank you.
| help_about.architecture = mock.Mock(return_value=('64bit', 'ELF')) | ||
| self.assertEqual(help_about._bitness(), '64') | ||
| platform.assert_called_with() | ||
| size.assert_not_called() |
There was a problem hiding this comment.
I have decided that these tests are way too much for something that almost does not need to be tested. Testing that the implementation is what we can see it is by reading the code is not very useful, though a common mistake. If the implementation is wrong, it is wrong. Reduce this to testing what we know must be true if there is no bug.
# untested ;-)
def test_build_bits(self)
self.assertIn(help_about.build_bits, (32, 64))
Put is some current class. Rename if needed.
There was a problem hiding this comment.
Thanks. I thought I needed to test each branch of the if for coverage. :-( I need to read more about writing good tests. Do you have any suggestions?
There was a problem hiding this comment.
If build bits were a real function, I would want to to try to hit all branches. And if we otherwise get to to 99'% coverage, I might want to do so, but it would be artificial. On Macs, the value of sys.architecture seems undefined, which is why it is not used. (Or I might just note that 99% is 100% of what is sensibly possible on any one system. ;-)
Read something about 'unit testing', such as parts of https://en.wikipedia.org/wiki/Unit_testing and 'test-driven development', such as the first half of https://en.wikipedia.org/wiki/Test-driven_development. There is clearly overlap. Keep in mind that both topics are subjects of programming religion.
No description provided.