Skip to content

bpo-42253: Update xml.dom.minidom.rst #23126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2021
Merged

bpo-42253: Update xml.dom.minidom.rst #23126

merged 3 commits into from
Oct 11, 2021

Conversation

jedie
Copy link
Contributor

@jedie jedie commented Nov 3, 2020 •
edited by bedevere-bot
Loading

The standalone arguments was added in Python 3.9. This information is missed in the docu.

https://bugs.python.org/issue42253

@jedie
Update xml.dom.minidom.rst
32b771c 
The `standalone` arguments was added in Python 3.9. This information is missed in the docu.
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Nov 3, 2020
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@jedie

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@jedie jedie changed the title Update xml.dom.minidom.rst bpo-42253: Update xml.dom.minidom.rst Nov 3, 2020
Fidget-Spinner
Fidget-Spinner reviewed Nov 3, 2020
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for your contribution to CPython!

For other reviewer's reference: the change being documented is found in commit dc04a05 .

The version it was added to is indeed 3.9. This LGTM, other than the minor backtick nitpicks. The backticks are causing the Travis CI build to fail too.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@BoboTiG
Copy link
Contributor

BoboTiG commented Aug 17, 2021

I just stumble upon the lack of documentation (I was thinking the keyword was always available as there was no Version added/changed: note :)

@jedie do you mind applying changes and fix conflicts 🙏 ?

@serhiy-storchaka serhiy-storchaka added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes skip news and removed CLA not signed stale Stale PR or inactive for long period of time. labels Oct 9, 2021
@serhiy-storchaka serhiy-storchaka merged commit c7e81fc into python:main Oct 11, 2021
@miss-islington
Copy link
Contributor

Thanks @jedie for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2021
@jedie @miss-islington
bpo-42253: Update xml.dom.minidom.rst (pythonGH-23126)
c50022f 
Document that the "standalone" parameter was added in Python 3.9.
Co-authored-by: Serhiy Storchaka <[email protected]>
(cherry picked from commit c7e81fc)

Co-authored-by: Jens Diemer <[email protected]>
@bedevere-bot
Copy link

GH-28874 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 11, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2021
@jedie @miss-islington
bpo-42253: Update xml.dom.minidom.rst (pythonGH-23126)
273c717 
Document that the "standalone" parameter was added in Python 3.9.
Co-authored-by: Serhiy Storchaka <[email protected]>
(cherry picked from commit c7e81fc)

Co-authored-by: Jens Diemer <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 11, 2021
@bedevere-bot
Copy link

GH-28875 is a backport of this pull request to the 3.9 branch.

serhiy-storchaka pushed a commit that referenced this pull request Oct 12, 2021
@miss-islington @jedie
bpo-42253: Update xml.dom.minidom.rst (GH-23126) (GH-28874)
3d7009e 
Document that the "standalone" parameter was added in Python 3.9.
Co-authored-by: Serhiy Storchaka <[email protected]>
(cherry picked from commit c7e81fc)

Co-authored-by: Jens Diemer <[email protected]>
serhiy-storchaka pushed a commit that referenced this pull request Oct 12, 2021
@miss-islington @jedie
bpo-42253: Update xml.dom.minidom.rst (GH-23126) (GH-28875)
2352890 
Document that the "standalone" parameter was added in Python 3.9.
Co-authored-by: Serhiy Storchaka <[email protected]>
(cherry picked from commit c7e81fc)

Co-authored-by: Jens Diemer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jedie @the-knights-who-say-ni @BoboTiG @miss-islington @bedevere-bot @serhiy-storchaka @Fidget-Spinner