Skip to content

bpo-42214: Fix check for NOTEQUAL token in the PEG parser for the barry_as_flufl rule #23048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2020
Merged

bpo-42214: Fix check for NOTEQUAL token in the PEG parser for the barry_as_flufl rule #23048

merged 2 commits into from
Oct 30, 2020

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Oct 30, 2020 •
edited by bedevere-bot
Loading

@pablogsal pablogsal added the needs backport to 3.9 only security fixes label Oct 30, 2020
lysnikolaou
lysnikolaou approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔫 🔫 The quickest one. I had just started working on this.

@pablogsal @lysnikolaou
Update Grammar/python.gram
7b178d4 
Co-authored-by: Lysandros Nikolaou <[email protected]>
@pablogsal
Copy link
Member Author

🔫 🔫 The quickest one. I had just started working on this.

🔫🤠

@pablogsal pablogsal merged commit 06f8c33 into python:master Oct 30, 2020
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 06f8c3328dcd81c84d1ee2b3a57b5381dcb38482 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 30, 2020
@bedevere-bot
Copy link

GH-23051 is a backport of this pull request to the 3.9 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request Oct 31, 2020
@pablogsal
[3.9] bpo-42214: Fix check for NOTEQUAL token in the PEG parser for t…
c89f06d 
…he barry_as_flufl rule (pythonGH-23048).

(cherry picked from commit 06f8c33)

Co-authored-by: Pablo Galindo <[email protected]>
pablogsal added a commit that referenced this pull request Oct 31, 2020
@pablogsal
[3.9] bpo-42214: Fix check for NOTEQUAL token in the PEG parser for t…
ddcd57e 
…he barry_as_flufl rule (GH-23048) (GH-23051)

(cherry picked from commit 06f8c33)

Co-authored-by: Pablo Galindo <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@pablogsal @adorilson
bpo-42214: Fix check for NOTEQUAL token in the PEG parser for the bar…
9b67161 
…ry_as_flufl rule (pythonGH-23048)
@pablogsal pablogsal deleted the bpo-42214 branch May 19, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees

@pablogsal pablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @miss-islington @bedevere-bot @lysnikolaou @the-knights-who-say-ni