Skip to content

bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all but processor) #23010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 31, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions Lib/platform.py
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,7 @@ class uname_result(
):
"""
A uname_result that's largely compatible with a
simple namedtuple except that 'platform' is
simple namedtuple except that 'processor' is
resolved late and cached to avoid calling "uname"
except when needed.
"""
Expand All @@ -797,12 +797,25 @@ def __iter__(self):
(self.processor,)
)

@classmethod
def _make(cls, iterable):
# override factory to affect length check
num_fields = len(cls._fields)
result = cls.__new__(cls, *iterable)
if len(result) != num_fields + 1:
msg = f'Expected {num_fields} arguments, got {len(result)}'
raise TypeError(msg)
return result

def __getitem__(self, key):
return tuple(iter(self))[key]
return tuple(self)[key]

def __len__(self):
return len(tuple(iter(self)))

def __reduce__(self):
return uname_result, tuple(self)[:len(self._fields)]


_uname_cache = None

Expand Down
34 changes: 34 additions & 0 deletions Lib/test/test_platform.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import os
import copy
import pickle
import platform
import subprocess
import sys
Expand Down Expand Up @@ -176,6 +178,38 @@ def test_uname_cast_to_tuple(self):
)
self.assertEqual(tuple(res), expected)

def test_uname_replace(self):
res = platform.uname()
new = res._replace(
system='system', node='node', release='release',
version='version', machine='machine')
self.assertEqual(new.system, 'system')
self.assertEqual(new.node, 'node')
self.assertEqual(new.release, 'release')
self.assertEqual(new.version, 'version')
self.assertEqual(new.machine, 'machine')
# processor cannot be replaced
self.assertEqual(new.processor, res.processor)

def test_uname_copy(self):
uname = platform.uname()
self.assertEqual(copy.copy(uname), uname)
self.assertEqual(copy.deepcopy(uname), uname)

def test_uname_pickle(self):
orig = platform.uname()
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
with self.subTest(protocol=proto):
pickled = pickle.dumps(orig, proto)
restored = pickle.loads(pickled)
self.assertEqual(restored, orig)

def test_uname_slices(self):
res = platform.uname()
expected = tuple(res)
self.assertEqual(res[:], expected)
self.assertEqual(res[:5], expected[:5])

@unittest.skipIf(sys.platform in ['win32', 'OpenVMS'], "uname -p not used")
def test_uname_processor(self):
"""
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Restore compatibility for ``uname_result`` around deepcopy and _replace.