bpo-41739: Fix test_logging.test_race_between_set_target_and_flush() #22655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test now waits until all threads complete to avoid leaking running threads. Also, use regular threads rather than daemon threads.
|
This fix should be backported to 3.8 and 3.9, but I will backport it manually to 3.9 because 3.9 doesn't have support.threading_helpers. |
pablogsal
approved these changes
Oct 11, 2020
|
"Windows (x86)": test_asyncio failed. It's unrelated to this issue and I'm not interested to debug an asyncio issue on 32-bit Windows. |
vsajip
pushed a commit
that referenced
this pull request
Oct 12, 2020
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 12, 2020
…ythonGH-22655) (pythonGH-22656) The test now waits until all threads complete to avoid leaking running threads. Also, use regular threads rather than daemon threads. (cherry picked from commit 13ff396) (cherry picked from commit f5393dc) Co-authored-by: Victor Stinner <[email protected]>
vstinner
added a commit
that referenced
this pull request
Oct 12, 2020
…H-22655) (GH-22656) (GH-22662) The test now waits until all threads complete to avoid leaking running threads. Also, use regular threads rather than daemon threads. (cherry picked from commit 13ff396) (cherry picked from commit f5393dc) Co-authored-by: Victor Stinner <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
…ythonGH-22655) The test now waits until all threads complete to avoid leaking running threads. Also, use regular threads rather than daemon threads.
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…ythonGH-22655) The test now waits until all threads complete to avoid leaking running threads. Also, use regular threads rather than daemon threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test now waits until all threads complete to avoid leaking
running threads.
Also, use regular threads rather than daemon threads.
https://bugs.python.org/issue41739