Skip to content

bpo-41876: Overload __repr__ for tkinter Font objects #22450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 14, 2020
Merged

bpo-41876: Overload __repr__ for tkinter Font objects #22450

merged 10 commits into from
Oct 14, 2020

Conversation

platonoff-dev
Copy link
Contributor

@platonoff-dev platonoff-dev commented Sep 29, 2020 •
edited by bedevere-bot
Loading

Put name of font instead of object address

https://bugs.python.org/issue41876

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@p4m-dev

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

serhiy-storchaka
serhiy-storchaka reviewed Sep 29, 2020
View reviewed changes
serhiy-storchaka
serhiy-storchaka reviewed Sep 29, 2020
View reviewed changes
E-Paine
E-Paine reviewed Sep 29, 2020
View reviewed changes
@E-Paine
Copy link
Contributor

E-Paine commented Sep 29, 2020 •
edited
Loading

@p4m-dev thanks for committing my suggestion. Please could you remove the trailing whitespace in the changes to the test file (I believe its on lines 103 & 106) - this is why Travis and Azure are failing.

E-Paine
E-Paine reviewed Sep 29, 2020
View reviewed changes
serhiy-storchaka
serhiy-storchaka reviewed Sep 29, 2020
View reviewed changes
@platonoff-dev
Copy link
Contributor Author

All done! Looks like all is OK now)

@E-Paine
Copy link
Contributor

E-Paine commented Sep 29, 2020

Um... Did you miss Serhiy's latest review?

@platonoff-dev
Copy link
Contributor Author

Yes, sorry, I miss it.

@E-Paine
Copy link
Contributor

E-Paine commented Oct 2, 2020

@p4m-dev just some housekeeping: as you have now resolved all the requested changes, please could you mark them as resolved (just makes it easier to see what's going on). @serhiy-storchaka please could you re-review as I believe the patch is now ready (the requested changes have indeed been made).

@platonoff-dev
Copy link
Contributor Author

All done)

@serhiy-storchaka serhiy-storchaka merged commit b4d8953 into python:master Oct 14, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@platonoff-dev
bpo-41876: Overload __repr__ for tkinter Font objects (pythonGH-22450)
d3cc4a8
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@platonoff-dev @adorilson
bpo-41876: Overload __repr__ for tkinter Font objects (pythonGH-22450)
138b451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@E-Paine E-Paine E-Paine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@platonoff-dev @the-knights-who-say-ni @E-Paine @serhiy-storchaka @bedevere-bot